search

statebox / cql

CQL: Categorical Query Language implementation in Haskell
GNU Affero General Public License v3.0
162 stars 14 forks source link

fix styling #60

Closed marcosh closed 5 years ago

marcosh commented 5 years ago

@wisnesky may I ask you how do you usally compile the code locally? It would be nice to have also locally the same habits, so we could trust the compiler and be done with styling issues

wisnesky commented 5 years ago

I'm using sublime text, which I've never used before. Suggestions for a better editor or better ide are welcome.

On Oct 10, 2018, at 12:47 PM, Marco Perone notifications@github.com wrote:

@marcosh requested your review on: statebox/aql#60 fix styling.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

marcosh commented 5 years ago

I meant which command do you use to compile the code. Do you use stack build or stack test?

Regarding the editor, I guess you can do almost the same things with anyone, integrating tools as ghci. For the record, I'm using visual studio code with some extensions (Haskell Syntax Highlighting, hlint), but mainly I'm looking at the output of stack test --fast --file-watch --pedantic in console

wisnesky commented 5 years ago

I usually use stack build.

On Oct 10, 2018, at 1:01 PM, Marco Perone notifications@github.com wrote:

I meant which command do you use to compile the code. Do you use stack build or stack test?

Regarding the editor, I guess you can do almost the same things with anyone, integrating tools as ghci. For the record, I'm using visual studio code with some extensions (Haskell Syntax Highlighting, hlint), but mainly I'm looking at the output of stack test --fast --file-watch --pedantic in console

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

marcosh commented 5 years ago

If I use stack build on the actual master, it does not compile. Does it compile for you if you use stack build --pedantic?

wisnesky commented 5 years ago

The version I pushed just now works with pedantic:

Ryans-MacBook:statebox_aql ryan$ stack build --pedantic

Warning: Specified file "ChangeLog.md" for extra-source-files does not exist

Warning: /Users/ryan/GitHub/statebox_aql/aql.cabal was modified manually. Ignoring /Users/ryan/GitHub/statebox_aql/package.yaml in favor of the cabal file. If you want to use the package.yaml file instead of the cabal file, then please delete the cabal file.

Warning: File listed in aql.cabal file does not exist: ChangeLog.md

Ryans-MacBook:statebox_aql ryan$

On Oct 11, 2018, at 2:07 AM, Marco Perone notifications@github.com wrote:

If I use stack build on the actual master, it does not compile. Does it compile for you if you use stack build --pedantic?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

marcosh commented 5 years ago

It actually looks that there are still issues: https://travis-ci.com/statebox/aql