Master is broken

[epost]

Hey folks, I wanted to integrate your changes and stumbled upon this:

erik@munin:~/dev/statebox $ git clone https://github.com/statebox/aql.git aql-master
Cloning into 'aql-master'...
remote: Enumerating objects: 248, done.
remote: Counting objects: 100% (248/248), done.
remote: Compressing objects: 100% (142/142), done.
remote: Total 854 (delta 148), reused 145 (delta 77), pack-reused 606
Receiving objects: 100% (854/854), 232.78 KiB | 578.00 KiB/s, done.
Resolving deltas: 100% (491/491), done.

erik@munin:~/dev/statebox $ cd aql-master/

erik@munin:~/dev/statebox/aql-master (master) $ stack build

Warning: Specified file "ChangeLog.md" for extra-source-files does not exist

Warning: File listed in aql.cabal file does not exist: ChangeLog.md
union-find-array-0.1.0.2: configure
union-find-array-0.1.0.2: build
multiset-0.3.4: configure
multiset-0.3.4: build
union-find-array-0.1.0.2: copy/register
multiset-0.3.4: copy/register
term-rewriting-0.2.1.1: configure
term-rewriting-0.2.1.1: build
term-rewriting-0.2.1.1: copy/register
Building all executables for `aql' once. After a successful build of all of them, only specified executables will be rebuilt.
aql-0.1.0.0: configure (lib + exe)
Configuring aql-0.1.0.0...
aql-0.1.0.0: build (lib + exe)
Preprocessing library for aql-0.1.0.0..
Building library for aql-0.1.0.0..
[ 1 of 23] Compiling Language.Common  ( src/Language/Common.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Common.o )
[ 2 of 23] Compiling Language.Options ( src/Language/Options.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Options.o )
[ 3 of 23] Compiling Language.Parser.LexerRules ( src/Language/Parser/LexerRules.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/LexerRules.o )
[ 4 of 23] Compiling Language.Parser.ReservedWords ( src/Language/Parser/ReservedWords.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/ReservedWords.o )
[ 5 of 23] Compiling Language.Parser.Generator.Generator ( src/Language/Parser/Generator/Generator.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/Generator/Generator.o )
[ 6 of 23] Compiling Language.Term    ( src/Language/Term.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Term.o )
[ 7 of 23] Compiling Language.Prover  ( src/Language/Prover.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Prover.o )
[ 8 of 23] Compiling Language.Parser.Parser ( src/Language/Parser/Parser.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/Parser.o )
[ 9 of 23] Compiling Language.Typeside ( src/Language/Typeside.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Typeside.o )
[10 of 23] Compiling Language.Schema  ( src/Language/Schema.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Schema.o )
[11 of 23] Compiling Language.Query   ( src/Language/Query.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Query.o )
[12 of 23] Compiling Language.Mapping ( src/Language/Mapping.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Mapping.o )
[13 of 23] Compiling Language.Parser.Typeside ( src/Language/Parser/Typeside.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/Typeside.o )
[14 of 23] Compiling Language.Parser.Schema ( src/Language/Parser/Schema.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/Schema.o )
[15 of 23] Compiling Language.Parser.Mapping ( src/Language/Parser/Mapping.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Parser/Mapping.o )
[16 of 23] Compiling Language.Instance ( src/Language/Instance.hs, .stack-work/dist/x86_64-osx/Cabal-2.2.0.1/build/Language/Instance.o )

/Users/erik/dev/statebox/aql-master/src/Language/Instance.hs:75:1: error: [-Wincomplete-patterns, -Werror=incomplete-patterns]
    Pattern match(es) are non-exhaustive
    In an equation for ‘nf''’:
        Patterns not matched:
            _ (Var _)
            _ (Fk _ _)
            _ (Gen _)
   |
75 | nf'' alg (Sym f as) = Sym f $ Prelude.map (nf'' alg) as
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

/Users/erik/dev/statebox/aql-master/src/Language/Instance.hs:78:1: error: [-Wmissing-signatures, -Werror=missing-signatures]
    Top-level binding with no type signature: nf''_ :: p -> a
   |
78 | nf''_ _ = undefined
   | ^^^^^

Completed 4 action(s).

--  While building custom Setup.hs for package aql-0.1.0.0 using:
      /Users/erik/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_2.2.0.1_ghc-8.4.3 --builddir=.stack-work/dist/x86_64-osx/Cabal-2.2.0.1 build lib:aql exe:aql-exe --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1

[marcosh]

81 solves this.

We have a little issue here. I still have to dig in it. It looks like that when Ryan compliles with stack build, the section

ghc-options:
- -Wall
- -Werror

contained in the package.yml file is ignored, so he doesn't get all the compiler errors

[wisnesky]

As of this email, I have no problem doing ‘stack build’ against the master branch.

On Oct 12, 2018, at 12:51 PM, Marco Perone notifications@github.com wrote:

81 solves this.

We have a little issue here. I still have to dig in it. It looks like that when Ryan compliles with stack build, the section

ghc-options:

• -Wall
• -Werror

contained in the package.yml file is ignored, so he doesn't get all the compiler errors

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[epost]

@wisnesky I think Marco means that the fact that you apparently had no problems building was the problem. :9 Our builds fail in case of any warning, and yours appears to be more lax. Maybe it's something with Stack. I do think I noticed some PRs being merged for with Travis had a failing build, and in principle we want to avoid that.

Anyway, it seems to be building without warnings or errors again now, thanks Marco!