search

statechannels / SCBridge-Wallet

MIT License
2 stars 3 forks source link

bug: can't send funds to arbitrary addresses #151

Closed geoknee closed 1 year ago

geoknee commented 1 year ago

If we try to "L1 pay" or "Bridge pay" to anything other than Bob's "state channel address", we currently end up falling fowl of a hardcoded line here:

https://github.com/statechannels/nitro-smart-contract-wallet/blob/03cfe52c2555ee612f7b3a7ae36caf13ba931754/src/Wallet.tsx#L273

Fixing that line is easy, but then the "L1 pay" just results in an error for most cases. We should clear this up.

Meta comment: "recipient" here in the UI is very ambigious. Should it be an ethereum address, or some other identifier?

geoknee commented 1 year ago

If we fix this, we can easily show off "l1 pay" by bringing up either a block explorer or an account in metamask.