search

statechannels / dispute-game

A prototype of the dispute game in typescript and solidity.
MIT License
9 stars 0 forks source link

Prototype relies on javascript number behaviour #29

Closed lalexgap closed 3 years ago

lalexgap commented 3 years ago

Unfortunately Solidity doesn't have support for fixed point numbers.. Instead solidity rounds to 0 when dividing numbers.

To simulate that behaviour in our prototype I have called Math.floor whenever we divide a value. This causes the tests to fail.

andrewgordstewart commented 3 years ago

sanity check: why can't I observe the failing test through GitHub?

Screen Shot 2021-09-20 at 11 45 26 AM

lalexgap commented 3 years ago

sanity check: why can't I observe the failing test through GitHub?

Screen Shot 2021-09-20 at 11 45 26 AM

It looks like GH actions don't get triggered unless there's an actual created PR. Now that I've created the PR you can see the failure here

kerzhner commented 3 years ago

@lalexgap anything else that remains here?

lalexgap commented 3 years ago

@lalexgap anything else that remains here?

No, I think this is complete with your PR.