search

statechannels / dispute-game

A prototype of the dispute game in typescript and solidity.
MIT License
9 stars 0 forks source link

Disputed step is not validated #33

Closed andrewgordstewart closed 3 years ago

andrewgordstewart commented 3 years ago

newDisputedStep is computed, but it is not validated that the disputed step is being replaced with a different step.

(This fact also seems missing from the spec?)

kerzhner commented 3 years ago

Currently, the following happens:

  1. The dispute witness is validated to ensure that the dispute hash is in the merkle tree.
  2. The last hash in the hash list replaces the dispute step. We ensure that the last hash is different from the disputed hash.

What other step(s) would you add?

andrewgordstewart commented 3 years ago

The last hash in the hash list replaces the dispute step. We ensure that the last hash is different from the disputed hash.

I did not see this!