search

statechannels / go-nitro

Implementation of nitro-protocol in Go
Other
37 stars 20 forks source link

Implement create-channels scripts #1375

Open kerzhner opened 1 year ago

kerzhner commented 1 year ago

The Typescript client has a create-channels utility that is useful for bootstrapping nitro nodes for manual tests. If we reimplement the utility in golang, we can use the utility when spinning up go-nitro nodes via docker. This allows for one make command to spin up an image with ledger and virtual channels created.

geoknee commented 1 year ago

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

kerzhner commented 1 year ago

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

We could, but this requires setting up node/yarn in docker. This will increase the docker image size and lengthen docker builds. Plus https://github.com/statechannels/go-nitro/pull/1408 is almost finished.

geoknee commented 1 year ago

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

We could, but this requires setting up node/yarn in docker. This will increase the docker image size and lengthen docker builds. Plus #1408 is almost finished.

Good point. I went down that path today when playing around with embedding the GUI into go-nitro using Docker. A bit of food for thought.