search

stateful / runme

DevOps Notebooks Built with Markdown
https://runme.dev
Apache License 2.0
1.19k stars 38 forks source link

Add type search/filter to TUI #298

Open sourishkrout opened 1 year ago

sourishkrout commented 1 year ago

When project-mode (look at more than just single file) is being used, and unnamed code blocks are allowed the list can get really long just with a few files (see screenshot below with 98 entries).

Ideally something that works similar to "backwards search history" in bash/zsh which likely filters on word-prefix but open to other suggestions. Would also need a recommendation how to trigger the search or whether it is always on.

image
mxsdev commented 1 year ago

Suggestion for fuzzy search: https://github.com/ktr0731/go-fuzzyfinder @duvanmonsa

duvanmonsa commented 1 year ago

@mxsdev I have an initial version using the library you shared, We need to define the correct flow and design before creating a PR image

mxsdev commented 1 year ago

Nice! Feel free to make a draft PR, we can always make changes from there 👍

duvanmonsa commented 1 year ago

Yep PR here https://github.com/stateful/runme/pull/300

rawkode commented 1 month ago

Sad to see that PR closed. This would be a fantastic feature and charm supports this behavior out of the box.

sourishkrout commented 1 month ago

Sad to see that PR closed. This would be a fantastic feature and charm supports this behavior out of the box.

@rawkode. The PR is closed because of the particular implementation. We still want the filter/search. The plan is to reimplement the TUI with charm's base models in the runtime beta sub-command group.