Closed christian-bromann closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Looking good! Couple thoughts:
Otherwise the workflow seems right on. 👍
- The runme files list uses quite a lot of space, i'd probably want it condensed to one line each, maybe small runme icon, filename and then a truncated grayed out path, also maybe grouped if there are many in one directory?
I condensed it a bit. I would still keep it on two lines because it better guarantees that users can see the full directory path. I was looking into grouping by directory but it is generally less likely that many markdowns are in the same directory. What do you think about this version:
- Runnable Markdowns
Modified widget title.
- "Download for integrated Marquee support" makes me think of leaving VS Code and downloading something, maybe "Install native VS Code support for Runme" or something?
Updated:
Let me know what you think!?
LGTM 👍
This pull request implements a new widget to promote Runme. It comes with the following states:
User has Runme not installed
Clicking on
Add to VS Code
will open this linkvscode://stateful.runme?command=setup&fileToOpen=https://gist.githubusercontent.com/christian-bromann/df97ce3dace21564ffdf1900400ec099/raw/0a9b29c979d61e17032c855b04dbc4f5b962f847/ThankYou.md
which basically will prompt the install procedure for Run with Runme.No Runme Files are found
If no markdown files are found in the workspace, the widget will ask whether the user wants to create one. If the link is click, it runs the Runme command
runme.new
.Open Runme Files
On click on the list item, the widget will run the
runme.openAsRunmeNotebook
command. There is a file listener registered so every markdown file added to the workspace or removed will have an impact on the list and automatically updates it.@sourishkrout @admc please let me know if the widget fills the requirements. If functionality wise we are happy with the state I can wrap up the work adding unit/e2e tests.