search

stateful / vscode-runme

DevOps Workflows Built with Markdown for VS Code
https://runme.dev
Apache License 2.0
186 stars 13 forks source link

Both CLI & integrated terminal don't play nicely with `gum` #1346

Closed sourishkrout closed 1 month ago

sourishkrout commented 3 months ago

Specifically: https://github.com/charmbracelet/gum

Repro cell: https://github.com/sourishkrout/vfarcic-crossplane-sql/blob/main/examples/google.md#google-project

1. In the notebook terminal, there some superfluous output (likely related to terminal emu colors):

You are now logged in as [[sebastian@stateful.com](mailto:sebastian@stateful.com)].
Your current project is [runme-ci].  You can change this setting by running:
  $ gcloud config set project PROJECT_ID
Create in progress for [https://cloudresourcemanager.googleapis.com/v1/projects/dot-20240513100845].
Waiting for [operations/cp.7258844518349197269] to finish...done.                                                                                                                  
Enabling service [[cloudapis.googleapis.com](http://cloudapis.googleapis.com/)] on project [dot-20240513100845]...
Operation "operations/acat.p2-591391837881-2794424d-29fe-4e70-8576-3425a836a7fd" finished successfully.
  Open https://console.cloud.google.com/billing/enable?project=dot-20240513100845 in a browser and set the billing account.
> ]11;rgb:0000/0000/0000\

2. In the CLI the gum prompts remain completely invisible.

Run the same cell using the CLI.

sourishkrout commented 1 month ago

I'm cautiously optimistic that the issue was fixed in gum itself. As of https://github.com/charmbracelet/gum/releases/tag/v0.14.1, I can no longer repro the issue.

https://github.com/stateful/vscode-runme/assets/250527/5f428afa-7ccf-4534-90b2-672ce70404f1

sourishkrout commented 1 month ago

Fixed upstream in gum itself.