Fix: Preserve identity IDs when IDT is disabled

stateful / vscode-runme

DevOps Notebooks Built with Markdown - VS Code extension

https://runme.dev

Apache License 2.0

194 stars 15 forks source link

Fix: Preserve identity IDs when IDT is disabled #1359

Closed pastuxso closed 3 months ago

pastuxso commented 5 months ago

The issue is that when IDT is turned off, identity IDs need to remain unchanged, even if they are included in a notebook.

This includes:

runme.dev/stageId: This is a new metadata field used to transfer the IDT during serialize/deserialize requests only when RunmeIdentity is UNSPECIFIED.
Updates to assertDocumentContains to only match a portion of the document.
Test updates

Closes: #1354

sourishkrout commented 4 months ago

@degrammer @pastuxso I'll be doing the review on this. Please don't request reviews from one the more people at once or jump in unprompted. Context and duplication of work is costly.

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
6.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sourishkrout commented 3 months ago

Closing as obsolete now that https://github.com/stateful/vscode-runme/pull/1449 is merged.