stateful / vscode-runme

DevOps Workflows Built with Markdown for VS Code
https://runme.dev
Apache License 2.0
183 stars 13 forks source link

Fix Foyle language id on cells #1389

Closed jlewi closed 1 month ago

jlewi commented 1 month ago
jlewi commented 1 month ago

Right now when I try to build this I get an error

npm ERR! invalid: @buf/stateful_runme.community_timostamm-protobuf-ts@2.9.4-20240515171834-148b5afad0df.3 /Users/jlewi/git_vscode-runme/node_modules/@buf/stateful_runme.community_timostamm-protobuf-ts

I'm guessing this is might be related to #1378 which says the proto changes need to be published.

jlewi commented 1 month ago

Confirmed; I cherry-picked this change onto the 3.5.7 branch and the build succeeded so I don't think the failure is related to my PR.

jlewi commented 1 month ago

I confirmed when I cherry-picked this onto the 3.5.7 it fixed jlewi/foyle#125

sourishkrout commented 1 month ago

Confirmed; I cherry-picked this change onto the 3.5.7 branch and the build succeeded so I don't think the failure is related to my PR.

Just merged that into main. Rebasing the branch should fix it too but cherry-pick will do.

jlewi commented 1 month ago

@sourishkrout I think this PR is ready for review. I rebased on main; I'm still seeing the build error. But when I cherry-picked this onto 3.5.7 it fixed the Foyle issue with cells not be executable.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sourishkrout commented 1 month ago

@sourishkrout I think this PR is ready for review. I rebased on main; I'm still seeing the build error. But when I cherry-picked this onto 3.5.7 it fixed the Foyle issue with cells not be executable.

🤔 it worked for me after I ran runme run setup (which runs npm install) to pull in the latest deps.