Closed jlewi closed 1 month ago
Need to merge #1554 and then rebase this PR. We should be able to drop all the changes prior to commit 7c3924a
@sourishkrout this is ready for review.
@sourishkrout this is ready for review.
Sounds good. Feel free to add me as one of the reviewers. A Slack bot reminds me twice a day about pending reviews.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
85.4% Coverage on New Code
0.0% Duplication on New Code
This PR switches from using gRPC and the timostamm client to using the connect client for unary completions. This makes the code consistent with what we are doing for the streaming completions with ghost cells.
The service definition is also published is part of Foyle's protos in the buf schema registry https://buf.build/jlewi/foyle/commits/commit/b69cd71876b144ca900524437d722a84 so we can remove the AI service defined in the runme buf package (https://github.com/stateful/runme/tree/main/pkg/api/proto/runme/ai) after this change is released.
The benefit of this change for users is that we can have a single configuration option AI Base URL for configuring the AIService. This will be used for all AI calls (unary or streaming). We can then remove the option FoyleAddress.
This will also allow us to simplify the Foyle server since we will be able to stop running gRPC and gRPC gateway. see jlewi/foyle#173