You only need to look at the last two commits - I could not figure out how to reduce the pull request down to those two commits. The changes I made include updated tests.
I have made two sets of changes:
1) I added the aliases: name, size & directory?, so the Entry class matches the Dir entry class. This change is in is the second to last commit.
2) Unix list entry parsing did not correctly handle the relative nature of files times. If the entry is less than 12 months old the year is not displayed. I did not account for this when I added extraction of the modified times.
If you would integrate these changes I would appreciate it. As well, I notice that the 3.1.1 gem was not prompted so that when one runs gem outdated it is not detected. Would you please prompt this one so that it is detected.
tigris
commented
13 years ago
Hi Shane,
Happy New Year.
You only need to look at the last two commits - I could not figure out how to reduce the pull request down to those two commits. The changes I made include updated tests.
I have made two sets of changes:
1) I added the aliases: name, size & directory?, so the Entry class matches the Dir entry class. This change is in is the second to last commit. 2) Unix list entry parsing did not correctly handle the relative nature of files times. If the entry is less than 12 months old the year is not displayed. I did not account for this when I added extraction of the modified times.
If you would integrate these changes I would appreciate it. As well, I notice that the 3.1.1 gem was not prompted so that when one runs gem outdated it is not detected. Would you please prompt this one so that it is detected.
With thanks Norbert