statelyai / xstate-viz

Visualizer for XState machines
https://stately.ai/viz
MIT License
434 stars 102 forks source link

Remove compaction on root node. Fixes #279 #334

Closed davidkpiano closed 2 years ago

davidkpiano commented 2 years ago

This PR removes compaction on the root node, which was causing ELK to fail with self-transitions on the machine.

CleanShot 2022-01-09 at 06 31 09@2x
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 076a5f91960abcd8b2637f413613d29307a6d8e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | xstate-viz-app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/BD8rbGi7LDKuzJAurbLgpATEx7Yt
✅ Preview: https://xstate-viz-git-davidkpiano-279-statelyai.vercel.app

davidkpiano commented 2 years ago

Can u add a simple test that would just verify that the machine gets visualized correctly?

Done, please re-review

davidkpiano commented 2 years ago

Looks OK from mobile :) out of curiosity - what does compaction usually do? Was this misconfigured on our end or can this be classified as Elk’s bug?

It's an ELK issue, I believe. The replies here suggest that it has to do with compaction: https://github.com/kieler/elkjs/issues/98