Open Andarist opened 2 years ago
Latest commit: 5bdf243602f0cd47f33362f0b3ba836d7ae0817b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
xstate-viz | ✅ Ready (Inspect) | Visit Preview | Jun 21, 2022 at 1:48PM (UTC) |
Goals of this PR:
<WebExtension/>
that eg. doesn't depend on Monocao anyhow or doesn't know anything about embed mode etc<WebExtension/>
and also to migrate closer to a single source of truth for styling (previously we were mixing SCSS with Chakra)In general, to review this PR it might be the easiest to just follow its commits. Most are self-contained refactoring pieces, with some minor bug fixes at the end.
I'm not super fond of some of those "customizable" points here - perhaps this could be structured in a better way. I feel though that the current shape of the code is manageable and we could always refactor stuff later. If you have any general thoughts on composition patterns for problems like this - I'm happy to discuss different tradeoffs etc.