statgen / bravo_api

Server side data processing and retrieval endpoints for BRAVO
MIT License
1 stars 2 forks source link

Refactor user login_disabled property to login_not_required #19

Open grosscol opened 1 year ago

grosscol commented 1 year ago

Issue or current state

The bailff blueprint provides auth status route that emits the application login configuration as an attribute of the user auth status. The application config app.config.get('LOGIN_DISABLED') is answering the question "Is the login manager disabled for this application?" An answer of True indicates that users aren't required to log in.

This is confusing when straight mapped as a user authentication status. Login disabled could mean that the user is no longer permitted to log in. It is intending to indicate that the user is not required to login.

Resolved when

API emits user auth status with login_not_required property instead of login_disabled.