statgen / demuxlet

Genetic multiplexing of barcoded single cell RNA-seq
Apache License 2.0
117 stars 25 forks source link

Add option to produce only singlets probabilities (fix #52) #55

Closed arogozhnikov closed 4 years ago

arogozhnikov commented 4 years ago

Proposing PR because running demuxlet against large number of genotypes drives to OOM

VincentGardeux commented 4 years ago

I think Fix #59 would fix the OOM issue

arogozhnikov commented 4 years ago

@VincentGardeux thanks for the info, but I already wrote my own demultiplexer for rnaseq, I can close this PR if you're confident that problem with too many genotypes was addressed in your patch.

VincentGardeux commented 4 years ago

@arogozhnikov yes the patch corrects the issue.

I did not change much the code, so I don't see any potential conflicts/bugs, but would be cool if would be tested on a test dataset at least by another user before merging (we tested it on several datasets and did not see any difference of output (to the byte).

Cheers