statgen / fivex

Interactive eQTL visualizations
MIT License
13 stars 3 forks source link

Merging of Single variant color switching + Data generation pipeline #10

Closed amkwong closed 5 years ago

amkwong commented 5 years ago

I want to merge my additions from the data_generation_pipeline branch #8 into Mukai's reorganized branch. My goal is to have one unified master branch from which we can work.

I am currently working on resolving the merge conflicts between the different versions.

amkwong commented 5 years ago

Looking at the listed conflict, it looks like the only file it's complaining about is index.html because I added an extra line. I just merged it in, so there should be no more conflicts.

amkwong commented 5 years ago

I've fixed some problems and done additional testing. I have successfully managed to run the data generation pipeline on both the StatGen cluster and my own Linux subsystem.

We should review this pull request, remove extraneous things, and merge it into master so we can work off the reorganized structure.

Quick setup instructions:

Notes:

abought commented 5 years ago

I've pushed some minor cleanup to this branch (mostly to reduce flake8/ eslint noise, and removing files that don't need to be in the repo).

With Alan's changes I'm seeing some errors trying to run the app: No such file or directory: 'data/gene.symbol.pickle'. Pausing review until we can sort that out, but look forward to merging soon!

amkwong commented 5 years ago

I generated and tested small files which should allow us to run the flask app directly from a git clone (after switching to this branch).

Currently pheget should run for the variant 19:6718376 from a fresh install with no additional installation or data processing.

abought commented 5 years ago

Looks good; merging!

Because this PR represented some initial trial and error, we have a lot of "noisy" commits in this branch (including some large files that were removed early on)

Therefore, this one time, I've squashed the entire PR into a single commit to clean all that up. I apologize for the bad etiquette of compressing commit history, but to compensate, I've created a CONTRIBUTORS.md to ensure you all got credit for your work.

There will be more commits (and lots more credit) in the future; thanks all!

amkwong commented 5 years ago

Thanks for the review and merge! We can all work from the master branch again finally.

We need to get this updated on the staging server (I'll ask Peter).