search

statgen / fivex

Interactive eQTL visualizations
MIT License
13 stars 3 forks source link

Better searchbox #12

Closed amkwong closed 5 years ago

amkwong commented 5 years ago

Improved search box behavior (ability to search by rs number) by delegating it to a separate script (searchbox.js).

Also, changed on-click behavior in grouped-by-gene view, to highlight all points matching the selected point's tissue instead of all points belonging to the same gene.

Side effect: it no longer retains the highlight when switching between group-by-gene and group-by-tissue, which is acceptable for now. We may want to reset highlighting when switching between group-by-gene and group-by-tissue.

amkwong commented 5 years ago

I fixed the errors and warnings from eslint for now, and should be ready for merge.

Will work on rewriting with the fetch API and refactoring as soon as I can get around to them.

abought commented 5 years ago

Will work on rewriting with the fetch API and refactoring as soon as I can get around to them.

Thanks! Room to refactor here, but I think first priority tomorrow will be to sit down and look at proposed feature spec again in light of Goncalo feedback, then see where the code goes accordingly.