Add a table below the PheWAS plot

statgen / fivex

Interactive eQTL visualizations

MIT License

13 stars 3 forks source link

Add a table below the PheWAS plot #21

Closed pjvandehaar closed 5 years ago

pjvandehaar commented 5 years ago

Ticket: #19

pjvandehaar commented 5 years ago

I like these changes, especially separating makeTable() from updateTable() and sorting pvalue vs beta as the y-axis changes. Seems mergeable to me.

abought commented 5 years ago

Thanks for taking a look! (everyone should be reviewed and it's a big plus for you to keep me honest)

There's one item from ticket #19 (the table filtering) that is not yet implemented, but I think we can do that as a followup. We're starting to track a lot of pieces of related state, and I may need to refactor this page to really handle that properly. (not just an additive change)