statgen / fivex

Interactive eQTL visualizations
MIT License
13 stars 3 forks source link

Updating search box and region view logic #43

Open amkwong opened 4 years ago

amkwong commented 4 years ago

The updates from #42 forces the region view to always have chrom, start, end, tissue, and gene_id, to help preserve and recreate the state of the current view. This leads to a few issues which need to be addressed:

abought commented 4 years ago

I see everyone is assigned. Who should be working on this?

Convention with project boards is toassign no one (open ticket, free to claim) or someone (who is then responsible).

amkwong commented 4 years ago

We can leave it open at the moment then and see if anyone wants to claim this.

amkwong commented 4 years ago

47 rewrote all requests using the Fetch API, and improved some of the search logic.

We still need to address the case in which the user searches for a single variant (chr:pos or rsnum) which cannot be found in our data. Currently, this kind of search leads to an error. I think the most useful way to handle this is to search for the top signal within a +/- 500kb region, then display the gene x tissue region plot containing that top signal.