statgen / fivex

Interactive eQTL visualizations
MIT License
13 stars 3 forks source link

Feature/credible set and single variant updates #75

Closed amkwong closed 3 years ago

amkwong commented 3 years ago

Ticket

71

Purpose

To add short gene names to the table on the bottom of the region view page. To accommodate this, we reprocessed credible_sets files, adding an extra column at the very end for short gene names for the merged (from multiple single-study files) and joined (to add p-values and other extra information) credible_sets data. We also changed the corresponding region view table formats to add these short gene names to the table. Includes a fix for a typo in the region view table (previously a column was labeled -log10(p-value), but the values were actually p-values; the values are now properly transformed to -log10(p-value), matching that in the single-variant view).

How to test this

Look at single-variant and region views to make sure the pages aren't broken Check the table to make sure the values are correct

Deployment / configuration notes

Need to replace old credible_sets files with updated files on the production server before deployment

abought commented 3 years ago

Overall the basic code seems ready to deploy (relying heavily on Alan to test, as I'm trying to reduce screen time heavily to help with eyestrain issues).

Let me know if you want this deployed tonight or after a few edits, such as updating the example links (which are user facing and therefore harder to defer). Will be back in an hour or so.

amkwong commented 3 years ago

I modified the parsing of p-values in CIParser so it matches that of VariantParser. The table appears to behave as expected, and nothing else broke as far as I can tell.

Please go ahead and deploy tonight if you get a chance. Also, please make sure the data files are moved to the correct locations on the production machine -- due to the format change of credible_sets files, the browser will break if it's trying to use the old files.

Thanks for the help!