statgen / localzoom

Make interactive LocusZoom plots from a local GWAS file
https://statgen.github.io/localzoom/
MIT License
7 stars 4 forks source link

Stating the expected headers #13

Closed carbocation closed 2 years ago

carbocation commented 3 years ago

In the locuszoom document about preparing data, which is linked from localzoom, the specific names of the expected data columns are not stated. It would be useful to list the names that can be automatically detected, so that we can more easily tell how to munge our file headers for easy compatibility with localzoom.

abought commented 3 years ago

Thanks for the feedback- we just added that link last night, and it's nice to hear that new features are noticed!

I agree about adding this to the documentation for a future release. As a general rule, we try to auto-detect columns using heuristics from a survey of common file formats; if the parser isn't recognizing your data, let us know and we will try to make improvements. Our goal is to handle a variety of common files out of the box.

For example, your bug report reminded me that some of the fields in the GWAS catalog standard file format were not being correctly detected, and this will be improved in a future release.

For your own reference until I can find time to revise the docs:

abought commented 2 years ago

I've made some improvements to the parser to handle the EBI format since our last conversation. I'll close this ticket for now.

There really isn't one exhaustive header list (because our parser tries to be flexible), so I think overly prescriptive docs might not be the way to go.

If anyone thinks that their file format could stand to be better supported, feel free to reach out with a list of example headers and we could try to improve the auto-detect features. Otherwise, I hope the example files and notes are useful. :)