search

statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

Manhattan Data Layer #112

Closed Frencil closed 4 years ago

Frencil commented 7 years ago

Work in progress, description forthcoming.

abought commented 7 years ago

As suggested, I've merged in #110 (docs PR). Since the docs PR doesn't touch code, the merge conflicts should be fairly isolated.

Frencil commented 7 years ago

Thanks @abought, the conflicts were pretty limited. This branch is getting a lot closer but still needs a bit more work. In the mean time though it is possible to see a functional proof of concept by checking out this branch and visiting the example page for it on localhost (something like http://localhost/locuszoom/examples/gwas_manhattan.html, depending on where locally you serve the locuszoom library static website).

abought commented 7 years ago

Tiny side note: I noticed a few lint commits, so just thought I'd mention that for convenience you can run npm test when it's time to apply the full set of tests used by Travis.

I didn't add ESLint to the gulp task simply because some people find it distracting to worry about style guides during the normal development flow. The npm script should help though.

abought commented 7 years ago

112 merged! (watch for merge conflicts)

Thanks again for inspiring the better and more configurable tick generation mechanisms; even before being officially released, this PR has (hopefully!) had a positive impact.

The branch in its released state doesn't yet have good unit tests around the tick generation mechanism. Your branch has a good start there, and I'm totally ok having the remainder of what is needed delegated back to me once this branch (and the finalized mechanism) is ready.

abought commented 7 years ago

Per meeting discussion today, this PR has been updated to point at the new develop branch, which is currently exactly the same as the contents of master.

In the future, updates for ongoing development would pull new code from develop (and new PRs will target this branch). Apologies for any turbulence!

abought commented 4 years ago

This PR is a bit stale; while we may reuse ideas in future I'm closing it due to merge conflicts.