statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

[rfr] Credible set visualization options #120

Closed abought closed 6 years ago

abought commented 6 years ago

🦑 This is a work in progress and should not yet be merged

Ticket

https://github.com/statgen/locuszoom/issues/39

Purpose

Implement credible sets with new visualizations. This PR exists to track state of work and make visible to others for collaboration. Some user-facing hooks are in flux or need unit tests added.

Summary of changes

TODO

Known issues

Testing notes

New functionality

Potential regressions

Release notes

LocusZoom 0.7.0

New features

Internal improvements

abought commented 6 years ago

This branch is largely feature complete. Tomorrow will be on various tidying, testing, and user feedback, with a target to package and release by noon Friday at the latest.

This PR adds a new dashboard button + new data layer type. Whether before or after the holidays, any feedback on desired features (or implementation gotchas) would be welcomed. (eg @Frencil etc) The actual calcs are implemented in a separate repo.

Hope everyone has an excellent break!

abought commented 6 years ago

Added some unit tests, and at least for the exact method, results match R output. (haven't manually ported over all the extreme value cases)

@welchr, current goal is to package this up and cut an LZ release by ~12pm tomorrow, based on current state of branch. I'll hold off if you have change requests and/or if we can't resolve @Frencil 's tooling issue report by that time.

Last call for tweaks!

EDIT: I've also added docs for the annotation track and display options to the wiki, since these are user-facing features of possible interest.

abought commented 6 years ago

Hmm. I'm tentatively marking the blocker as resolved, based on a few trials (below). If problems persist, please let me know and we can investigate further.

I've run the build/install process with 6.4, 5.12, 6.12 (LTS-6), and 8.9.3 (LTS-8), on old (6+ months) as well as new copies of the repo and on a different computer. I also tried with wiping node_modules after each install (to ensure bad dependencies weren't getting "grandfathered in").

The one issue I saw could be solved by good old npm rebuild node-sass --force; after that assets could be built normally on all machines/versions.