statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

"Download image" button uses hard-coded CSS filename #125

Closed abought closed 4 years ago

abought commented 6 years ago

Problem

The "download image" button sometimes saves images incorrectly- the most obvious symptom is a black background to the plot or missing gene data. This has been reported on some newer versions of PheWeb.

Evaluation

The download code tries to minimize what styles are included, by looking for a hardcoded filename locuszoom.css.

An alternative solution would be to only include styles matching a rule, perhaps the lz prefix- some exploration would be required.

Scope

Most LZ usages in the wild would not be affected. When seen, the problem is cross browser, various LZ versions.

Apps will only be affected if they rename the CSS file where LocusZoom code is contained- the particularly likely scenario is if the consuming app uses an asset pipeline, concatenating into vendor.css. Most of the research sites we support do not use sophisticated tooling.

abought commented 4 years ago

Will be fixed in #193