search

statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
156 stars 29 forks source link

Move to native Promise. #161

Closed lrowe closed 5 years ago

lrowe commented 5 years ago

Avoids extra dependency on Q.

abought commented 5 years ago

Thanks for the submission! Before I merge, I'd like to do a round of regression testing (probably early next week) on various deployments- but this is something I've been wanting to see deprecated for a while.

We always welcome pull requests- let us know if you have any other ideas in mind. Promise is ripe for use because it is very amenable to polyfilling, and we have recently been working on better support for modern build workflows that can do that automatically. Much of the modernization work is being piloted in our LocalZoom tool, eg module support.

abought commented 5 years ago

Regression tested in FF, Chrome, and Safari with no problems observed. A thorough and well executed conversion- thanks for your contribution! It will go out in our next release.