statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
156 stars 29 forks source link

Issue with geneLZ datasource URL #226

Closed cgrace1978 closed 3 years ago

cgrace1978 commented 3 years ago

I am using the geneLZ datasource within a "standard_association" plot with the API url: https://portaldev.sph.umich.edu/api/v1/annotation/genes/ The gene panel is working in some instances and not-working in other instances, I have included screen shots of two test pages I have generated.

HTML with gene panel working: image

image

HTML with gene panel not working:

image

image

abought commented 3 years ago

Thanks for the report.

The error you are showing appears to be due to the external API (gnomAD) that we query for gene constraint information.

Two thoughts come to mind:

  1. The version of LocusZoom you are using (0.10.1) is rather old. Newer versions (eg 0.12.2) have improved how we handle error messages from that API (we will still display gene information, just not overlay constraint info).
  2. We did introduce some minor breaking changes in 0.12.x, though I think the changes would be trivial for the example code you show. If using the older version is a firm requirement, we can assist you in disabling the gene constraint part of the request. (it involves understanding and modifying some aspects of LZ layout syntax though: upgrading versions is usually easier)

Does your error still occur with the newest LZ.js version? (newest stable version is 0.12.2)

cgrace1978 commented 3 years ago

I've updated locuszoom.js to the latest version and now the genes are loaded correctly. Thanks for the help!