statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
156 stars 29 forks source link

Floating point error with high -log10 p-values? #276

Closed VasLem closed 2 years ago

VasLem commented 2 years ago

Hi, I would like to mention that there is an issue with the numerical processing of the -log10 p-values, the highest it gets is 31.38 . This causes a wrong report of the highest peaks to show up if higher peaks than this number exist.

abought commented 2 years ago

Thanks for the report. Can you provide an example link where you are seeing this problem?

Also, is there a typo here (should this be referring to, eg, ~300)?

General notes:

We're used in many different websites- some via tabix, others via custom backends. It's hard to say exactly where the problem is without knowing which tool you use.... but I'd start by looking at the steps where data is read and sent to the browser.

If this is for a private site, I can be reached at abought@umich.edu for any direct links that you don't want to share on a public forum.

sir4ur0n commented 2 years ago

My 2 cents: I agree with @abought : I also use LZ and I have values way over 31 (even over 300) and it works just fine: image

abought commented 2 years ago

No reply from original author after ~3 weeks. I'm going to close this ticket to keep the backlog clear, but feel free to reopen if there's anything we can do to be of assistance.