statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

Expand Tick Controls #49

Closed Frencil closed 8 years ago

Frencil commented 8 years ago

What

In looking at expanding the LocusZoom platform to handle PheWAS plots it became clear that finer control over the positioning and appearance of axis ticks would be necessary. This branch iterates over how axis layouts can be built and interpreted to provide this new level of fine-grain control.

Details

Ticks actually used by a panel are no longer stored in the layout but on the panel object itself. This opened up the ability to define discrete ticks in the layout and have them interpreted into the panel object.

Discrete tick definitions in the layout can be done by specifying x offsets, style objects, and transform objects to create arbitrarily many ticks with individual control over color and geometry, allowing for LocusZoom to support the PheWAS-style x tick pattern.

Two new values have also appeared in the StandardLayout to preserve consistent rendering:

MrFlick commented 8 years ago

Looks good to me. Happy to merge. Did you want to take a pass @pjvandehaar ?

Frencil commented 8 years ago

Thanks for the review, @MrFlick. I'm going to go ahead and merge since I've got another branch off of this one ready for review.