statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

Panel UI #56

Closed Frencil closed 8 years ago

Frencil commented 8 years ago

Overview

This branch expands panel-level user interface to include the following:

Note that for the standard layout there is some dummy data in there for panel titles and descriptions that we'll likely want to remove or replace in consideration with how the Broad will consume the standard layout. Personally I think that such information is very implementation-specific and thus doesn't really belong in the standard layout at all.

Next week when we're working with Broad devs we can look at pulling things out of the standard layout into a Broad portal custom layout defined in their environment, or possibly look at spinning off a new layout (BroadPortalLayout?) that can live in the core library for now and allow the standard layout to be a bit more general.

Feedback / Release outlook

While code review is always in season this branch is heavily about integration--how the final product feels to use. Is the new UI introduced on the branch intuitive? Clean? Is it obvious how it's supposed to work, and does it actually work that way? Where does it feel a bit clunky, or a bit loose?

It will be a subjective call as to when this branch is ready for master as the last 5% of any tight and snappy UI is a long tail that isn't necessarily in scope of this branch. It would be good to get this rolled into new release (0.3.9) by EOD Monday, May 23 in advance of the next integration session with LocusZoom's current primary consumer.

MrFlick commented 8 years ago

This functionality looks good! If you can just clean up the conflicts, I'd be happy to merge.

Frencil commented 8 years ago

Thanks! This was a fun branch. I've spotted a couple of areas I'd like to continue to refine but they're nuanced and it's time to keep moving. Conflicts should be resolved now.