statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.
https://statgen.github.io/locuszoom/
MIT License
154 stars 29 forks source link

Fix `onUpdateFunctions` iteration issue #65

Closed mssand-b closed 8 years ago

mssand-b commented 8 years ago

Per #64, should fix the issue where adding functions to onUpdateFunctions causes undefined to be added to onUpdateFunctions

Fixes #64

Frencil commented 8 years ago

Thanks for catching that, @mssand-b! I'm going to close this pull req, though, as the change needs to be made in the source that gets compiled down to locuszoom.app.js (see ebb0858 as well as development setup documentation).

Since this was a very minor correction I just applied it on master. If you find yourself wanting to fix bugs you find in the core in the future, though, please take a look at the development setup instructions and if anything is ambiguous or unclear please let me know. It should be relatively quick to set up the proper node environment to run builds.