Use an intermediary AST in LZ.parseFields()

statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.

https://statgen.github.io/locuszoom/

MIT License

154 stars 29 forks source link

Use an intermediary AST in LZ.parseFields() #92

Closed pjvandehaar closed 7 years ago

pjvandehaar commented 7 years ago

This avoids some of the odd behavior of the previous conditional-template implementation. If the AST were cached it could also be much faster, but oh well.

Frencil commented 7 years ago

Looks good. FYI all library JS and tests are linted using the rule set here (see latest commit on branch where I cleaned up some linting issues). Something to keep in mind for future dev work.