Make mouse guides toggle-able via layout

statgen / locuszoom

A Javascript/d3 embeddable plugin for interactively visualizing statistical genetic data from customizable sources.

https://statgen.github.io/locuszoom/

MIT License

154 stars 29 forks source link

Make mouse guides toggle-able via layout #96

Closed Frencil closed 7 years ago

Frencil commented 7 years ago

As documented in this issue, sometimes mouse guides aren't wanted. They should still be on by default, but should be hooked to a layout directive (at the plot level) that can be set to false to prevent them from rendering.

pjvandehaar commented 7 years ago

[x] Set layout.mouse_guide to true or false for each LZ.Layouts.get('plot', ...)
[x] Make Plot.initialze only do things related to mouse_guide if layout.mouse_guide.
- [x] it would be cleaner if the this.mouse_guide and the this.interaction.dragging parts of mousemove were in separate functions.
[x] Update docs

PR https://github.com/statgen/locuszoom/pull/97

pjvandehaar commented 7 years ago

I just edited https://github.com/statgen/locuszoom/wiki/Plot#supported-layout-directives