statgen / pheweb

A tool to build a website to browse hundreds or thousands of GWAS.
MIT License
158 stars 65 forks source link

Support build 38 #113

Closed pjvandehaar closed 3 years ago

pjvandehaar commented 5 years ago
abought commented 5 years ago

For LZ.js datasources (the portaldev web API), see discussion on the #Locuszoom channel in our slack today. Basically, the current status is as follows:

If you haven't looked at the required LZ updates yet, feel free to create a ticket in that repo and assign me as help needed. We can discuss this (and GWAS catalog) tomorrow.

abought commented 5 years ago

Adding relevant PR link: https://github.com/statgen/locuszoom/pull/149

This PR will add LD and gene support for h38. It's a work in progress, as we're still beta testing the new LD server a bit (see checklist for plans and future directions).

abought commented 5 years ago

For the Locuszoom side of this task:

Build 38 support has been merged into LZ.js develop branch, including use of new LD and Recomb rate API data. (thanks, Ryan and Daniel!) Gene data was already available.

If you specify genome_build: 'GRCh38' in plot.state, all LZ.js data sources will automatically choose a dataset appropriate to that build. Would this help reduce the amount of custom code needed for your configuration?

Here is an example showing what that looks like (notice that most sources no longer encode a source: value of their own) https://github.com/statgen/locuszoom/blob/develop/examples/gwas_catalog.html#L86-L111

abought commented 4 years ago

To help track work and blockers: the separate genelocator package handles build38 .

I've also got some RSID parsers that operate on the new DB snp build 153 format, for both genome builds 37 and 38. Let me know what would be useful to get this moving.