statgen / pheweb

A tool to build a website to browse hundreds or thousands of GWAS.
MIT License
158 stars 65 forks source link

Region page: new LD source, pop selector, LZjs 0.10 #130

Closed abought closed 4 years ago

abought commented 4 years ago

Ticket: #128

Purpose

The old LD server is deprecated, but collectively, newly created PheWebs represent a major source of traffic.

We should update PheWeb to use the new LD server, including features such as the new "choose LD population" picker with more available populations.

How to test this

abought commented 4 years ago

I've updated the layout a bit further so that the phewas plots work with category scatter. But it could use review + testing as I have very limited test data available, and the field names I chose may not be correct for the original intent.

I've separated formatting vs content changes into separate commits for ease of review.

abought commented 4 years ago

Per peter's question yesterday: Daniel has confirmed that the NaN workaround (for the old API server) can be safely removed when using the new LDServer source. ("LDServer gives “null” in JSON where value is not available")

abought commented 4 years ago

Following up on review of this ticket.

Are there any requests or blockers? What can I do to help move this forward?

abought commented 4 years ago

This seems to have been merged Feb 25 in 982de8c . Is there any further work needed?

Otherwise I'll close this ticket and clear it from my list of things to follow up on. :)

pjvandehaar commented 4 years ago

Yes, the main commit was merged.