statgen / pheweb

A tool to build a website to browse hundreds or thousands of GWAS.
MIT License
154 stars 65 forks source link

Fixes to cluster feature #164

Closed frankp-0 closed 3 years ago

pjvandehaar commented 3 years ago

Oh, thanks! Those were pretty glaring bugs in retrospect.

I like that you created a new directory inside generated-by-pheweb/tmp. That's a nice change.

I'm glad you're so good at sorting through this code to find problems.

pjvandehaar commented 3 years ago

I changed this code a little at https://github.com/statgen/pheweb/commit/df1530809e0821b53dd5feb1e405277d1a74c9bc#diff-775a4ed6610e46475b726ba3526cb5f52220c6d6e9f6e25acf6490e5d23df0ba . The previous code for checking which phenotypes needed to run was wrong, but now it looks good. I haven't tested this, but it looks good to me. It's in version 1.3.15 now.