statgen / pheweb

A tool to build a website to browse hundreds or thousands of GWAS.
MIT License
154 stars 65 forks source link

Update PheWeb for changes in LZjs 0.14.0 #185

Open abought opened 2 years ago

abought commented 2 years ago

🦑 Hold for final release of LZ 0.14.0

Purpose

The next release of LocusZoom makes breaking changes to how data is retrieved. This PR updates PheWeb to work with the new version, and introduces small user-facing benefits in terms of larger font sizes and a more concise legend for association plots. This will help people to use figures from PheWeb in publications or presentations.

Blockers

Hold for the final release of LocusZoom.js 14, so that we can update the version string in this PR before merge. (I'm hoping that will happen soon)

Testing notes

pjvandehaar commented 1 year ago

No, there's not a branch that uses logpvalue. The python needs to check for pval==0 and then it's fine.

What needs to happen to merge this? Update to 14.0 (no beta) and test?

abought commented 1 year ago

What needs to happen to merge this? Update to 14.0 (no beta) and test?

Hi Peter!

In general the branch changes should work well, but I didn't exhaustively test every feature of PheWeb (and due to breaking LZ 14 layout syntax changes, it needs a little more attention to testing than I had bandwidth for back then).

At very least the branch should mostly function for what I did test: I don't think I made any major edits to LZ between December and when v14 was actually released (there was a long holding period due to external partners).

As for the pvalue/logpvalue issue: as long as PheWeb is happy with current situation, we're good. I do like storing things as logp where possible (esp for things like top hit detection, as modern gwas seem to have more extreme hits)..... but that architectural change is probably not in scope based on pheweb's current "all volunteer" maintenance situation.

(I've changed projects as well, and don't presently have the time to backport the top hit & qq revisions from my.lz.org, which uses the logp internally. Ah well.)