added possibility to hide download button for top hits and phenotypes

statgen / pheweb

A tool to build a website to browse hundreds or thousands of GWAS.

MIT License

154 stars 65 forks source link

added possibility to hide download button for top hits and phenotypes #190

Closed Sergey-Knyazev closed 2 years ago

pjvandehaar commented 2 years ago

This looks great! Nice work figuring out how conf.py works even though I didn't document it.

Could you make one change before I merge this PR? I'd prefer if you used overrides['show_download_top_hits_button'] = False instead of overrides['hidden_download_top_hits_button'] = True. And likewise, use def should_show_download_top_hits_button() instead of def is_hidden_download_top_hits_button(). I get confused by all the double negatives.

Sergey-Knyazev commented 2 years ago

Sure, I will do that.

Sergey-Knyazev commented 2 years ago

Done!