search

statgen / savvy

Interface to various variant calling formats.
Mozilla Public License 2.0
26 stars 5 forks source link

Probably typo in assert #33

Closed serzero2007 closed 4 months ago

serzero2007 commented 4 months ago

Here:

template <typename AggregateT>
    AggregateT dot_slow(const self_type& other, AggregateT ret) const
    {
      assert(size_ = other.size_);
      ...
      return ret;
    }

Probably must be == instead of =.

https://github.com/statgen/savvy/blob/82fb57602ccabb23ba5a686444102e842c382d28/include/savvy/compressed_vector.hpp#L424

jonathonl commented 4 months ago

Thanks for reporting. This has been fixed with https://github.com/statgen/savvy/commit/5d0cd9da476223e2bbe1c85d02601fbe148aadbb.