search

stathissideris / dali

dali is a Clojure library for representing, exporting and manipulating the SVG graphics format.
291 stars 16 forks source link

Add string rendering #10

Closed pfeodrippe closed 5 years ago

pfeodrippe commented 6 years ago

I needed to render a xml string to create a pdf in my job. As commented at #9 by @stathissideris, the code works.

stathissideris commented 6 years ago

Hello Paulo, thanks for the PR, I really appreciate it. Would you mind adding a couple of unit tests to it? Nothing complicated, just a couple of short documents to assert that the strings produced are what we expect. Thanks!

pfeodrippe commented 6 years ago

Hi @stathissideris, gonna do it :)

pfeodrippe commented 6 years ago

@stathissideris Is it good?

marco-m commented 5 years ago

hello @stathissideris any chance to have a look at this PR ? Thanks!

stathissideris commented 5 years ago

Sorry it took an incredibly long amount of time to merge this!

kengruven commented 5 years ago

Cool. Can we have a new release with this feature please?

(There doesn't seem to be any way to tell lein to just grab a git head.)

stathissideris commented 5 years ago

@kengruven just released as 0.7.5