Closed dakusui closed 5 years ago
@stathissideris , I tried hard to fix the code formatting issue, but I found it's quite a bit painful. Maybe we should reformat the entire project first and resume working on this feature if it's hard to review even if we use "Ignore white space changes" feature of GitHub. Can you please provide a code formatting style for some IDE such as Eclipse or IntelliJ? Or any style guideline if you have?
I have stopped working with Java for many years, so I don't have a preferred style. Are you using the Intellij defaults?
I can use IntelliJ's default, but the one I am using daily basis is the following one which has 2 characters for indentation to save horizontal space, no tabs to be portable, etc.
https://github.com/dakusui/jcunit/tree/0.8.x-develop/src/site/resources/style
2 characters and spaces sounds like a reasonable default to me. Could you please send me a new PR on the current master that applies that to the whole project? Then you can git rebase this PR on the new master and continue work. Thanks!
Understood, I have opened this pull request #43 for it.
I've created another branch that contains this branch's content and pull request which is directed from it to a code formatted branch. The diff is available here. I think this is reviewable and we should create a new pull request to be merged from it eventually.
Please do not look into this pull request anymore. Refer to this one for review.
@stathissideris I have invited you to my forked repository as a collaborator for the review's sake. Please find an email from github or let me know to send it to you.
This is a pull request that offers an implementation of Issue-#39 (LaTeX math mode support) NOTE: Please do not look into this pull request anymore. Refer to this one for review. NOTE: This pull request is opened for review and discussions. Another pull request will be created when it becomes necessary.
README
Following is a documentation about this feature. This will appear in README.md after discussions are concluded.
Usage and syntax
Command line
(snip)
(snip)
Syntax
(snip)
LaTeX mode.
If you place LaTeX formulae inside 2
$
s, it will be rendered usingjlatexmath
. That is, if you have a following input files.This will be rendered as follows.
Limitations
This feature is only available when you are generating
.png
files.Discussions
.svg
support should be done in a separate pull-request since it would be a bit big change.Tasks
*
is rendered as a bullet point (or a connector?) even if it is placed inside$
and$
.pom.xml
pom.xml
toproject.clj