Webpack 5 Support / Refactoring

statianzo / webpack-livereload-plugin

LiveReload during webpack --watch

ISC License

203 stars 51 forks source link

Webpack 5 Support / Refactoring #64

Closed web-mi closed 3 years ago

web-mi commented 3 years ago

I have refactored the code a little bit and added support for webpack 5 but webpack 4 is still be supported. Maybe it should be released as major but it should not include any breaking changes.

Webpack 5 support
Refactored logic from prototype class to class
Switched from done hook to afterEmit because webpack v5 shrinks assets to SizeOnlySource Changelog
Added config validation
Restructured options from single attributes to options attribute

Fixes #63

web-mi commented 3 years ago

@statianzo could you tell me why you unset delay option for tiny-lr? I could not find any usage of delay in tiny-lr but won't remove it because i don't know why you removed it.

web-mi commented 3 years ago

Changes are done. I refactored the listen function a little bit. The package.json now includes the peerDependency for webpack and engines for node version. And i have added a changelog file.

I tried everything with node 10 too and it works so required node version is >= 10.

statianzo commented 3 years ago

@statianzo could you tell me why you unset delay option for tiny-lr? I could not find any usage of delay in tiny-lr but won't remove it because i don't know why you removed it.

It came as part of #38. Likely being conservative about what gets passed through to tiny-lr, to prevent issues if it were to add delay.

statianzo commented 3 years ago

Released v3.0.0. Switched to github actions for CI because travis seems to no longer run.

Thanks again @web-mi