static-dev / axis

terse, modular & powerful css library
http://axis.netlify.com
Other
320 stars 45 forks source link

New categories / utilities cleanup #191

Closed dbox closed 9 years ago

dbox commented 9 years ago

@jenius The utilities folder seems pretty unwieldy to me. Should we:

Move the following to typography:

Create images (media?) category and move the following over:

Create a layout category and move the following over:

Move border-box-html to reset

Which would leave the rest feeling very much like utilities:

Thoughts? Moving stuff around shouldn't have any compatibility issues should it?

jescalan commented 9 years ago

Agreed, I think those moves you suggested are appropriate, and it will not cause any breakage or issues, just general organization. Feel free to PR this guy in :+1:

dbox commented 9 years ago

So here's what I'm thinking:

//cc @ccampb13

jescalan commented 9 years ago

Looks like a solid plan to me. Although I don't want to add autoprefixer as a dependency. I feel like it should be up to the user whether they want to use autoprefixer. We could perhaps include it as a convenience option that's off by default, but I don't want to force it. However I am not set in stone so if you have a compelling reason I could be convinced otherwise!

dbox commented 9 years ago

Basically the only thing I get hung up on when running tests is the vendor prefixes. So was hoping it'd make that easier, but i'm fine either way.

dbox commented 9 years ago

Also, just worried how much of nib's vendor prefix stuff it's currently using.

jescalan commented 9 years ago

Yeah, I'm entirely ok with running the tests without vendor prefixes. I just don't feel like prefixing is our job anymore. Autoprefixer is great at taking care of this, so we should just leave it to them entirely.

jescalan commented 9 years ago

We'll just have axis output solid modern css, and let AP take care of old browsers and such

dbox commented 9 years ago

Great. Still not looking forward to all the tests :) But sounds like @abstracthat is down for helping out and I believe @ccampb13 is as well.

ccampb13 commented 9 years ago

@jenius, Working on setting up testing for the scss port of axis and running into an issue. In test/fixtures/.styl files, you are calling the mixin. When I attempt to do the same I receive a "no mixin named button" error. Where in the setup do you import the mixins from axis/.styl to be used in the test directory?

On Tue, Jun 16, 2015 at 2:23 PM, Daniel Box notifications@github.com wrote:

Great. Still not looking forward to all the tests :) But sounds like @abstracthat https://github.com/abstracthat is down for helping out and I believe @ccampb13 https://github.com/ccampb13 is as well.

— Reply to this email directly or view it on GitHub https://github.com/jenius/axis/issues/191#issuecomment-112535833.

Chad Campbell 615-429-2280

zspecza commented 9 years ago

@ccampb13 that would be here: https://github.com/jenius/axis/blob/master/test/test.coffee#L13

Axis imports itself using the JS API: https://github.com/jenius/axis/blob/master/index.js#L14

I don't think there's an equivalent way of doing implicit importing in Sass, so you have carte blanche on how you want to handle that

ccampb13 commented 9 years ago

thanks @declandewet, stylus continues to impress

dbox commented 9 years ago

@jenius @abstracthat Should border-box-html be part of the new layout or part of reset?

abstracthat commented 9 years ago

It’s a reset utility when applied globally I would say.