Update variable names / future-proofing

static-dev / axis

terse, modular & powerful css library

http://axis.netlify.com

Other

320 stars 45 forks source link

Update variable names / future-proofing #201

Closed dbox closed 9 years ago

dbox commented 9 years ago

I think we tackle this before #192.

Per conversation on https://github.com/declandewet/stylus-conventions/issues/8#issuecomment-124158817

We need to:

[x] Add $ to all variables
[x] Unify all variable names to be $dash-case
[x] ~~Reference @declandewet's conventions doc in contributing?~~

zspecza commented 9 years ago

I'm not so certain on the last one :chicken:, my conventions doc has gone seriously unmaintained because of my limited time to devote to open source at my current job

dbox commented 9 years ago

FWIW I think the community needs such a doc, but i'm fine to cross off #3.

dbox commented 9 years ago

I have this almost done. It was not trivial. Post update on this soon.

dbox commented 9 years ago

Done in #209

Probably should make this v0.5.x. Not sure if there would be any breaking changes but better safe than sorry.

So up next v0.4.3:

adds rule()
adds hover-glow() and hover-float()
adds click-down(),click-inset(), click-shadow(), & click-shrink()
moves print to reset

v0.5.0

new variable structure.

v0.5.1

select-box()
??
??

Then we'll push dropping nib to v0.6.x

jescalan commented 9 years ago

Good roadmap. I'm going to get some stuff merged today, sorry for the delays!

dbox commented 9 years ago

Honestly I didn't expect the nib removal to go so quickly. Not sure we even really need to have new variable structure be it's own release now. We can just roll it out with the sans-nib update.