search

static-dev / axis

terse, modular & powerful css library
http://axis.netlify.com
Other
320 stars 45 forks source link

Option to remove round borders #296

Closed alanaasmaa closed 8 years ago

alanaasmaa commented 8 years ago

Option to remove round borders.

jescalan commented 8 years ago

I'm sorry, could you add a little more detail to this issue?

alanaasmaa commented 8 years ago

@jescalan I would like to remove border-radius from everything.

jescalan commented 8 years ago

What do you mean by "everything"? Let's get started by listing out elements you are interested in.

alanaasmaa commented 8 years ago

Buttons, fields, inputs

jescalan commented 8 years ago

Awesome -- ok the next step is to fork the repo and add the option, then open up a pull request with the changes 😁

jescalan commented 8 years ago

...or close the issue! haha

alanaasmaa commented 8 years ago

Im pretty new to this kind of stuff and i don't have time right now to dig into it. I will try do to this later. I closed the issue cause this is not that kind of "issue". Haha

dbox commented 8 years ago

chants 👏 ALAN! ALAN! You can do it!

jescalan commented 8 years ago

open source is all about teamwork! get your name on that contributor list, the glory will be worth it

dbox commented 8 years ago

Maybe something like this?

settings.styl


// Set to null to remove all rounded borders
$global-border-radius = 3px

code.styl

code($color = #DF5C33)
  padding: 3px 4px
  color: $color
  background-color: #F5F5F5
  border: 1px solid #E1E1E8
  font-family: Menlo, Monaco, $monospace

  if $global-border-radius
    border-radius: $global-border-radius
alanaasmaa commented 8 years ago

@dbox thanks for the tip. When i looked the code i was thinking it would be more practical to give button or input field one more option

button($color,$size,$text-color,$border-radius) then it would not be global. And maybe someone would like to make different fields look a bit different. Also global default would be creat too.

dbox commented 8 years ago

I'd say if you're going to pick and chose which ones get it, might as well just do it in the css code. No point in passing that many arguments for every mixin.