Referenced PR exposed issue that nested options objects being passed from the API are not merged properly with options from App.js – Because Object.assign copies the full reference over if the value of a key:value pair is an object. This was leading to server options set in App.js being ignored.
This PR fixes this issue by changing the way options are merged to use a method suitable for nested objects.
There is a new test to check that the merge is operating properly.
jescalan
commented
7 years ago
Relates to static-dev/spike#38
Referenced PR exposed issue that nested options objects being passed from the API are not merged properly with options from
App.js– BecauseObject.assigncopies the full reference over if the value of a key:value pair is an object. This was leading to server options set inApp.jsbeing ignored.This PR fixes this issue by changing the way options are merged to use a method suitable for nested objects.
There is a new test to check that the merge is operating properly.