static-dev / spike-core

:warning: UNMAINTAINED :warning: A modern static build tool, powered by webpack
https://spike.js.org
Other
58 stars 9 forks source link

An in-range update of browser-sync is breaking the build 🚨 #216

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 2.18.8 of browser-sync just got published.

Branch Build failing 🚨
Dependency browser-sync
Current Version 2.18.7
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

As browser-sync is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:


Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/static-dev/spike-core/builds/201255631)
Release Notes 2.18.8

FIXED: re-implemented reloadDebounce to better suit the Browsersync use-case. Now we debounce and buffer events to allow multiple files to be injected following the specified window of event silence.


FIXED: de2e2fa added watchEvents option to solve #1291 - now you can override which file-watching events Browsersync will respond to.

For example, if you wanted to respond to the add event, along with the default change event, you could provide the following

   browser-sync start --server --files "app/src" --watchEvents change add

or

const bs = require('./').create();

bs.init({
    server: 'app',
    files: ['app/src'],
    watchEvents: ['add', 'change']
});

FIXED: c6d7d16 always send override: true on public notify method to fix #538

This means you can now silence the default notify messages, whilst still using your own.

const bs = require('./').create();

bs.init({
    server: 'app',
    notify: false
});

setInterval(function() {
    bs.notify('5 seconds have passed!')
}, 5000);
Commits

The new version differs by 11 commits .

  • 9e0a170 2.18.8
  • a6bba5a ignore all file change events if codeSync: false
  • 2229394 limit file handling to core namespace
  • 5b00707 Merge branch 'reload-debounce'
  • 4b14c3b chore: cleanup/comments
  • 9d741d0 ensure stream api also conforms to reloadDelay and reloadDebounce
  • a1fbcf0 rework reloadDebounce
  • de2e2fa fix(files): added watchEvents option
  • 5d1e084 deps: bump browser-sync-client re: BrowserSync/browser-sync#538
  • 7e36ce1 tests: update for override: true on public notify message
  • c6d7d16 fix(notify): always send override: true on public notify method

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree: