static-dev / spike

A modern static build tool, powered by webpack
http://spike.js.org
Other
470 stars 29 forks source link

Timestamp in spike watch output #77

Open utx0 opened 6 years ago

utx0 commented 6 years ago

Be great to have a timestamp in the spike watch output.

Am just starting to get my hands dirty converting a html theme to a spike site and am finding myself while debugging this process never quite sure if/when the compiler has run.

If you guys are open to this enhancement i'll have a crack at adding it if you want?

jescalan commented 6 years ago

Sure, would love to have that feature! I think it would be a great first time contributor feature as well. Let me know if you need help!

jescalan commented 6 years ago

Just following up on this one!

utx0 commented 6 years ago

Sorry bro, I haven't had anytime of late to get back to anything to do with spike. :(

Kind regards, Luke Hamilton Solutions Architect | Web & Mobile Developer | Digital Nomad

-- e: luke@mettadata.com s: lukekhamilton c: https://calendly.com/lukekhamilton/ https://calendly.com/lukekhamilton/

~ With loving kindness ~

On Sat, Dec 16, 2017 at 2:25 AM, Jeff Escalante notifications@github.com wrote:

Just following up on this one!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/static-dev/spike/issues/77#issuecomment-352048396, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFhoyKOgYHU3deZAuSKgiGNRkvA8xEHks5tAp14gaJpZM4QI7Uw .

adamkiss commented 6 years ago

@jescalan I could tackle this - I'm using a fork of spike with ^HEAD spike-core where I already added it, albeit hard-coded, and I could use some sort of direction. I'd also like to add a 'this file changed, rebuilding…' to watcher - I have already figured it out how, and I'm adding it here as it's also under the umbrella of 'verbosity'

The timestamp

The timestamp is/should be added to spike/bin/cli.js, but where should the config value come in from? As far as I can see, there is no config values going from app.js to cli, only e.g. port settings overriding app.js?

The watcher - file changed

This one needs three components - webpack hook, some sort of spike <=> cli emit function, and also should read some config from somewhere. I ~have the webpack hook figured out, but I am not sure where to add it. Possibly spike-core/plugin.js?

Thanks

jescalan commented 6 years ago

Hey @adamkiss! I think probably the best way for me to work through this with you, to be honest, would be to jump on a video call for like an hour and just talk it through. I have been really overloaded with work these days, so the best way for me to keep my attention in one place is to set up a specific date/time to handle it. Want to shoot me a time on slack that's good for you and maybe we can just hammer it out?