static-frame / arraykit

Python C Extensions for StaticFrame
Other
8 stars 2 forks source link

Add annotations for compiler errors/warnings. #37

Closed brandtbucher closed 3 years ago

brandtbucher commented 3 years ago

@chaburkland @flexatone What do you think of this?

If you click on the "Files changed" tab above, you can see compiler warnings and errors from our builds inline with the actual code. That way we don't need to dig through the build logs to find them. You can see that there are actually two Windows-specific warnings that we haven't been aware of, where we should be using npy_intp instead of int (which are different widths on Windows)!

(I'm testing this out on ArrayKit; if we like it, I can set up similar annotations for the quality checks in our main repo.)